[Bug 34143] Support for clearing logs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34143

Emilio Pozuelo Monfort <pochu27 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ with small fixes
                 CC|                            |pochu27 at gmail.com

--- Comment #2 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-02-10 11:48:37 PST ---
+_tpl_rmdir_recursively (const gchar *dir_name)

+  dir = g_dir_open (dir_name, 0, &error);

You're not reading error, so just pass NULL instead of passing error and
freeing it.

+    <method name="Clear"
+            tp:name-for-bindings="Clear">
+      <tp:docstring>
+        Clear all the log. This will not erase the favourite contacts.

logs

+tpl_dbus_service_clear_entity (TplSvcLogger *logger,

+  entity = g_object_new (TPL_TYPE_ENTITY,
+      "type", type,
+      "identifier", identifier,
+      NULL);

You're leaking entity.

Other than that looks good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.