[Bug 34316] UpdateParameters: bad handling of DBus_Property and Has_Default in Unset argument

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34316

--- Comment #7 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-21 09:53:18 PST ---
(In reply to comment #6)
> I like this. One niggle to prove I really read it:
> 
> +    if (!check_parameters (account, protocol, params, unset, dbus_properties,
> +                           not_yet, &error))
> +    {
> +        g_hash_table_unref (dbus_properties);
> +        g_ptr_array_unref (not_yet);
> +        goto error;
> 
> +    g_hash_table_unref (dbus_properties);
> +    g_ptr_array_unref (not_yet);
>      tp_connection_manager_protocol_free (protocol);
>      return;
> 
> It might be nice to have goto finally; and then error: then finally: so that
> all the memory is released in one location -- since my first question was
> whether or not the error path free'd @protocol.

Quite right. Fixed slightly differently, at Nicolas’ suggestion:
<http://git.collabora.co.uk/?p=telepathy-mission-control.git;a=commitdiff;h=718d297>

… and merged to master as
<http://git.collabora.co.uk/?p=telepathy-mission-control.git;a=commit;h=a4ca0e6>.
Sadly I introduced a regression. There's a fix at
<http://git.collabora.co.uk/?p=user/wjt/telepathy-mission-control-wjt.git;a=commitdiff;h=a137d57>.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.