[Bug 33589] Channel-specific nicknames

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33589

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-21 11:32:33 PST ---
+        <tp:error name="org.freedesktop.Telepathy.Error.InvalidArgument">
+          <tp:docstring>
+            Raised when the new nickname contains invalid characters
+            and has been rejected by the server.
+          </tp:docstring>
+        </tp:error>

It can be rejected by either the client or by the server.

For instance, maybe my server supports Unicode 6 while my client only supports
Unicode 5, so my client might think that 👀 is not a valid character, even
though my server would accept it; or vice-versa.

+        <p>If the CHANNEL_GROUP_FLAG_CAN_SET_OWN_NICKNAME flag is
+          set on the channel, request the user's channel-specific
+          nickname changes. This method is only available in group
+          chats where users can have room-specific nicknames, such as
+          XMPP.

Why is that in SHOUTY CASE? It should be something like
“<code>Can_Set_Own_Nickname</code> flag is set in
<tp:member-ref>GroupFlags</>”… And the second sentence is kind of redundant
with the first. So maybe

“If the <code>Can_Set_Own_Nickname</code> flag is set in
<tp:member-ref>GroupFlags</>—on protocols where users can have room-specific
nicknames in chatrooms, such as XMPP—request the user's channel-specific
nickname changes.”?

+      <p>An interface on connections which is used to specify a
+        default nickname to be used when joining group chats which
+        support channel-specific nicknames.</p>

This is back-to-front. “An interface, implemented on connections where the user
can choose a different nickname for themselves in each group chat they join, to
specify the user's default nickname in chat rooms.”

+        <p>If this property is empty, the CM MUST use an appropriate
+          nickname when joining channels which support room-specific
+          nicknames.</p>

MUST + woolly terms like “appropriate” seems a weird juxtaposition.

+        <p>Note that changing this property will not affect any
+          currently open room channels which support channel-specific
+          nicknames. To do this, <tp:dbus-ref

Why not?

+        <p>To ensure that all rooms which support channel-specific
+          nicknames have the same nickname, the <tp:dbus-ref
+         
namespace="ofdT.Connection.Interface">RoomNickname.DRAFT.DefaultNickname</tp:dbus-ref>
+          property should be changed by calling <tp:dbus-ref
+          namespace="ofdT.Account">UpdateParameters</tp:dbus-ref>.</p>

But you just said that that property doesn't update existing nicknames.

+        <p>Note that if the change is a success then the user's self
+          handle in the channel will change as an existing handle cannot
+          change its meaning. As a result, success is notified by the
+          <tp:member-ref>SelfHandleChanged</tp:member-ref> signal being
+          emitted.</p>

The first sentence needs some punctuation.

It's kind of confusing that this interface refers throughout to “nickname” when
it actually means the Group.SelfHandle property. (Which has no Group.SelfID
relative, I notice.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.