[Bug 29457] TpAccountChannelRequest: request-and-observe helper
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Tue Feb 22 15:53:27 CET 2011
https://bugs.freedesktop.org/show_bug.cgi?id=29457
Will Thompson <will.thompson at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|review- |review+ with nitpicks
--- Comment #11 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-22 06:53:26 PST ---
in observe-channels-context.c and handle-channels-context.c:
+ tp_proxy_get_dbus_daemon (self->account),request_props);
Coding style: there should be a space here ^^
* @connection and @channel may be %NULL your telepathy-mission-control is
- * too old.
- * TODO: put the actual version of MC implementing this.
+ * too old (< 5.7.1).
Aside from the missing “if”, this sentence would be more clearly written as
something like:
“With telepathy-mission-control version 5.7.1 and earlier, @connection and
@channel will be %NULL. When using newer versions, they will be correctly set
to the newly-created channel, and the connection which owns it.”
+ * Deprecated: since 0.13.UNRELEASED. Use
+ * #TpChannelRequest::succeeded-with-channel instead
“Use #..., which provides the resulting channel, instead.”
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the telepathy-bugs
mailing list