[Bug 34716] Split wocky_porter_register_handler up to make sender matching more explicit.
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Feb 25 16:23:13 CET 2011
https://bugs.freedesktop.org/show_bug.cgi?id=34716
Jonny Lamb <jonny.lamb at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |review+
--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-02-25 07:23:12 PST ---
If you'd put your register_handler_va implementation AFTER the old
register_handler implementation it would have been a lot easier to review. :-(
Anyway, it looks fine. I like the way there are now three functions for the
three cases, it makes things really explicit what's going on.
I didn't really review all the test changes in depth, but yay go go go. Who's
going to update gabble? :-P
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list