[Bug 34716] New: Split wocky_porter_register_handler up to make sender matching more explicit.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34716

           Summary: Split wocky_porter_register_handler up to make sender
                    matching more explicit.
           Product: Wocky
           Version: unspecified
          Platform: Other
               URL: http://git.collabora.co.uk/?p=user/wjt/wocky.git;a=sho
                    rtlog;h=refs/heads/register-handler-from
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: General
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


Currently we have:

+guint wocky_porter_register_handler (WockyPorter *self,
+    WockyStanzaType type,
+    WockyStanzaSubType sub_type,
+    const gchar *from,
+    guint priority,
+    WockyPorterHandlerFunc callback,
+    gpointer user_data,
+    ...) G_GNUC_NULL_TERMINATED;

If 'from' is NULL, stanzas from anyone are matched. There is no way to match
stanza from the server.

The attached branch splits this function into three:

• wocky_porter_register_handler_from(), which accepts a non-NULL 'const gchar
*from' argument;
• wocky_porter_register_handler_from_anyone(), which matches stanzas from any
sender;
• wocky_porter_register_handler_from_server(), which matches stanzas from the
server, using the same logic as matching IQ replies from the server.

It also fixes a bug where matching JIDs without a node part, like
"example.com", would actually match stanzas from anyone.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.