[Bug 34840] New: Doesn't strip newlines from kick/part/ … messages

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34840

           Summary: Doesn't strip newlines from kick/part/… messages
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Keywords: love
          Severity: normal
          Priority: medium
         Component: idle
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


While reviewing Chandni's fix for bug 34812, I noticed that newlines aren't
stripped from the PART message that's built. This means that if you quit #foo
as follows:

    RemoveMembers([self_handle], "bye bye\r\nPRIVMSG #telepathy :hai guise")

then the following will be sent on the wire:

    PART #foo :bye bye
    PRIVMSG #telepathy :hai guise

rather than the intended:

    PART #foo :bye bye PRIVMSG #telepathy :hai guise

That is: the second half of the message will be interpreted by the server as a
separate command. This is a contrived example, of course.

The same bug afflicts kick messages. A quick grep suggests there might be a few
other places with this bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.