[Bug 32611] Implement Room interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32611

--- Comment #5 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-01-03 08:47:51 PST ---
(In reply to comment #3)
> Moar newlines to group parameter pairs (or pair in this case) please, as per
> /Style

Done.


> g_assert (ok) then, so it's genuinely used and not just assigned to a useless
> variable? Or, explicitly cast the return to (void), which iirc silences that
> warning.

Done.

> +    # Now a channel which already exists (any of the above) with
> +    # RoomID set.
> +    jid = 'booyakasha at conf.localhost'
> +    call_async(q, conn.Requests, 'EnsureChannel', {
> +            cs.CHANNEL_TYPE: cs.CHANNEL_TYPE_TEXT,
> +            cs.TARGET_HANDLE_TYPE: cs.HT_ROOM,
> +            cs.TARGET_ID: jid,
> +            cs.ROOM_ROOM_ID: '',
> +            })
> +
> +    e = q.expect('dbus-error', name=cs.INVALID_ARGUMENT,
> method='EnsureChannel')
> 
> I'm not convinced this should fail: the empty RoomID isn't really part of the
> identity of the channel, surely? We're requesting the same room as before, but
> this time providing the information that its name is meaningless, which we
> neglected to provide first time round.

Ah yes, I misread "Requests with conflicting TargetID and RoomID properties
will fail with InvalidArgument."

I've fixed this in my room branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.