[Bug 32611] Implement Room interface

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 3 18:27:05 CET 2011


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
  Status Whiteboard|                            |review-, minor changes

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-01-03 09:27:05 PST ---
> -  /* The target ID has already been checked

I'd prefer a similar comment reinstated above the g_assert, to explain why it's
safe to do so.

> +      g_assert (gabble_decode_jid (target_id, &a, NULL, NULL));

Assertion with side effects detected! Deserves a similar comment, perhaps "/*
JIDs that are handles must already be valid */".

Both of those also apply to the block below, for Server.

I'd prefer @a and @b to be called target_room and target_server, or something.

>      # Now a channel which already exists (any of the above) with
> -    # Server set.
> +    # a conflicting Server set.
> +            cs.ROOM_ROOM_ID: 'happynewyear',

Copy-paste error in the comment, but bonus penguin points for your choice of
room ID (and happy new year to you too).

/moar-room looks good.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list