[Bug 32691] Support addressing in TpBaseProtocol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32691

Eitan Isaacson <eitan.isaacson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-, minor changes      |

--- Comment #2 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2011-01-03 16:14:07 PST ---
(In reply to comment #1)
> (This can't be merged until the undrafted spec has landed and been released.)
> 
> I'm not really sure that Addressing should be in the TpBaseProtocol vtable:
> we're running out of slots, and Addressing doesn't seem particularly
> fundamental. Maybe it should be a GInterface (see how TpBaseContactList does
> its optional functionality, for instance). I could be persuaded either way.

That would be a good use of GInterface, I was having a hard time taking up two
more precious slots. Plus, I don't like the get_details function, I think they
should each be a separate one, but I was conserving slots. Anyway, the HEAD has
this implemented as a GInterface along with all the other review bits you gave.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.