[Bug 32611] Implement Room interface

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jan 4 09:49:32 CET 2011


--- Comment #8 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-01-04 00:49:31 PST ---
(In reply to comment #7)
> > -  /* The target ID has already been checked
> I'd prefer a similar comment reinstated above the g_assert, to explain why it's
> safe to do so.


> > +      g_assert (gabble_decode_jid (target_id, &a, NULL, NULL));
> Assertion with side effects detected! Deserves a similar comment, perhaps "/*
> JIDs that are handles must already be valid */".


> I'd prefer @a and @b to be called target_room and target_server, or something.


> Copy-paste error in the comment, but bonus penguin points for your choice of
> room ID (and happy new year to you too).


All pushed to room as usual.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list