[Bug 31274] Call: NewCodecOffer signal should contain the properties of the optional CodecOffer interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31274

--- Comment #8 from Sjoerd Simons <sjoerd at luon.net> 2011-01-05 10:53:19 PST ---
> > +    <signal name="LocalDescriptionsChanged"
> > 
> > In practice, do several local descriptions really change atomically? If not,
> > it'd be a lot simpler to have a LocalDescriptionChanged (which implies Added if
> > necessary) and a ...Removed. Likewise for RemoteDescriptionsChanged.
> 
> FIXME

Removed is now one signal for both  (as it will alwyas apply to both at the
same time)

> > The semantics of NewDescriptionOffer look as though it ought to be called
> > DescriptionOfferChanged - it seems astonishing to have a NewFoo signal when a
> > Foo is deleted.
> 
> fixed, FIXME should require to always go via DescriptionOfferDone though

required!

> > > The contact handle that this codec offer applies to or 0 a description
> > > that will apply globally.
> > 
> > "0 for a description that"
> > 
> > "... that will apply to all remote contacts in the _Call_" perhaps?
> 
> FIXME clarify what this mean
> 
> > Department of namespacing: some of the type names seem pretty vague. I think
> > it's OK for the Content.Media interface to just have "Description" in its
> > property/signal names, because in the context of a Call, the prevailing meaning
> > for "description" is (perhaps) the SDP one.
> >
> > However, types are a flat global namespace (in our codegen) and if I say
> > "description" with only Telepathy as context, I'd expect it to be some sort of
> > human-readable blurb about a chatroom or something. Perhaps the types could say
> > Media_, so we get Media_Description_Properties:a{sv},
> > Contact_Media_Description[_Properties]_Map:a{ua{sv}} and
> > Media_Description_Offer:(oua{sv}), or something?
> > 
> > I'd be very tempted to rename Description_Properties to Description_Description
> > :-)
> 
> FIXME

Changed the name to Media_Description, not  Description_Description because
that would be silly :p


All issues are now fixed, please re-re-review :) There is one open FIXME to
clarify the usage of 0 a bit more , but i'm going to punt on that one a bit
more

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.