[Bug 32153] Account Storage commit() virtual method not optional (as claimed in docs)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 6 10:21:06 CET 2011


Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
  Status Whiteboard|                            |review+

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-01-06 01:21:05 PST ---
-    old_string = mcd_storage_dup_string (storage, name, key);
     new_string = g_value_get_string (value);

-    if (!tp_strdiff (old_string, new_string))
-    {
-        g_free (old_string);
-        return SET_RESULT_UNCHANGED;
+    if (*new_string == '\0') {
+        new_string = NULL;

What if the value GValue hasn't had a string set to it yet? g_value_get_string
will return NULL and *NULL isn't so cool.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list