[Bug 32153] Account Storage commit() virtual method not optional (as claimed in docs)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32153

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-06 03:33:26 PST ---
(In reply to comment #4)
> -    old_string = mcd_storage_dup_string (storage, name, key);
>      new_string = g_value_get_string (value);
> 
> -    if (!tp_strdiff (old_string, new_string))
> -    {
> -        g_free (old_string);
> -        return SET_RESULT_UNCHANGED;
> +    if (*new_string == '\0') {
> +        new_string = NULL;
>      }
> 
> What if the value GValue hasn't had a string set to it yet? g_value_get_string
> will return NULL and *NULL isn't so cool.

As discussed IRL this is actually safe because dbus-glib never gives you
GValues containing NULL strings. But I've amended the patch to use
tp_str_empty; and merged it. Cheers! This fix will be in 5.7.2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.