[Bug 27270] TplLogManager: clean up API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 7 00:04:54 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=27270

--- Comment #15 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-01-06 15:04:54 PST ---
(In reply to comment #14)
> We need to abstract this somehow and stop exposing "gboolean chatroom" all over
> the public API. See bug #32477. They seem to be exposed so tp-logger knows
> whether to add "chatrooms/" to the URI to look for the logs.
> 
> We should remove that from the API, maybe adding a generic way to specify the
> event type if we really need that, e.g. with a TplLogType type arg, with
> TplLogType being an enum with TPL_LOG_TYPE_CHATROOM, _CALL, _FILE_TRANSFER, etc
> values.
> 
> Opinions? I can probably get to this soon.

I've hacked something along these lines in
http://git.collabora.co.uk/?p=user/pochu/telepathy-logger.git;a=shortlog;h=refs/heads/generic-log-manager-api-27270

I still need to port empathy to the new API and make sure everything is working
fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list