[Bug 31274] Call: NewCodecOffer signal should contain the properties of the optional CodecOffer interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31274

--- Comment #10 from Sjoerd Simons <sjoerd at luon.net> 2011-01-10 09:11:27 PST ---
> In LocalMediaDescriptionsChanged and RemoteMediaDescriptionsChanged, is the map
> a diff, or a new value for the property? (I assume it's a diff, so keys that
> are omitted from the change notification stay the same.)

Yeah, it's only the descriptions that were updated, as it says: ``The local
content descriptions that were updated'' and not ``The local descriptions''

Would you like to see it spelled out a bit more?

> +      <arg name="Removed_Media_Descriptions" type="au">
> 
> tp:type="Contact_Handle" I assume? It'd be nice to clarify that members of this
> list are removed from the keys of both maps (I assume that that's what
> happens).

It talks about the local _and_ remote media descriptions that are no longer a
part of... Is that not clear enough ?

> +    <property name="MediaDescriptionOffer"
> 
> In a multi-user call, can we have more than one of these active? I assume the
> answer must be "no" - is that because it can't arise anyway, or is it enforced
> by the CM not announcing a new media description until the previous one has
> been processed?

No indeed, see also the text on NewMediaDescriptionOffer

> +    <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> +      This object represents a remote Description Offer to which the local
> +      streaming implementation should reply with its local Description
> +    </tp:docstring>
> 
> If Description is well-known jargon, perhaps you could hyperlink to SDP or
> Jingle or something for the definition?

It's well-known but imprecise jargon. I'd rather not refer to things that are
vaguely similar, if people know about SDP and a bit about jingle Description
will sound familiar otherwise it's not worth explaining its roots really..

> +    <method name="Reject" tp:name-for-bindings="Reject">
> +      <tp:docstring>
> +        Reject the proposed update to the remote description
> +        FIXME add error codes and strings here
> +      </tp:docstring>
> +    </method>
> 
> I hope there's a bug for that :-)
#32971

> Is the contact handle in a Media_Description_Offer and/or
> Contact_Media_Description_Properties_Map redundant with the
> MediaDescription.RemoteContact?

Yes, added a reference from the map definition now

> Please open a bug for the Remote_Contact = 0 thing, unless you plan to leave
> this bug open after merging to represent it.
#32972

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.