[Bug 19930] Close() on MUC channels should probably be asynchronous

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 12 19:54:23 CET 2011


--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-12 10:54:23 PST ---
Oh, and does this deal correctly with:

1. UI calls Close()
2. UI calls Disconnect()
3. Server echoes our presence to say we've left the room

Definitions of correctly include:

• The channel emits Closed() when Disconnect() is called; and doesn't crash
when the presence arrives. I believe this works by accident: when Disconnect()
is called, the muc factory tells the channel to close without waiting, and then
unrefs the channel, which happens to destroy it, which has the effect of
destroying the WockyMuc so WockyMuc::parted will not fire and crash us.
• The channel doesn't emit closed until either the presence is echoed, or
Gabble gets bored of waiting for the stream close from the server.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list