[Bug 32874] Offline contacts does not have capabilities

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 12 20:04:14 CET 2011


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
  Status Whiteboard|NB#209774                   |NB#209774 review- trivia

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-12 11:04:13 PST ---
I think the implementation is functionally fine. But here's a bunch of trivia.

+  /* IM factory */
+  GabbleImFactory *im_factory;

This comment does not add anything except unnecessary scrolling.

+Test for fd.o#32874

I'm offline on a train. What was that bug?

+    # new ContactCapabilities
+    ccaps_map = conn.ContactCapabilities.GetContactCapabilities([bob_handle])
+    assertEquals(1, len(ccaps_map))
+    assertEquals(1, len(ccaps_map[bob_handle]))


+    assertSameSets({cs.CHANNEL_TYPE: cs.CHANNEL_TYPE_TEXT,
+                    cs.TARGET_HANDLE_TYPE: cs.HT_CONTACT}, fixed)


+    print all_caps


I'm upset that there's no convenience function to expect a roster query and
send a reply, but I won't hold it against you.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list