[Bug 32611] Implement Room interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32611

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |

--- Comment #11 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-01-13 01:34:40 PST ---
(In reply to comment #10)
> I think it'd be kinder to give more information. How about: "TargetID's node
> part (%s) doesn't match RoomID (%s)". Ditto the one below.

Done.

> (In reply to comment #8)
> > > > +      g_assert (gabble_decode_jid (target_id, &a, NULL, NULL));
> > > 
> > > Assertion with side effects detected! Deserves a similar comment, perhaps "/*
> > > JIDs that are handles must already be valid */".
> > 
> > Done.
> 
> No it hasn't been done for the conflict-checking section. You added comments
> above the assertions, but didn't make them side-effect-free.

Oh, right, I misunderstood what Simon said. Done.

> Surely it must be possible to avoid repeatedly decoding the JID and
> asserting about it?

Maybe. Suggestions?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.