[Bug 32085] Write tests for StreamedMedia

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 13 18:06:25 CET 2011


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
  Status Whiteboard|                            |basically review+

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-13 09:06:24 PST ---
This looks good to me. I'm gonna have to trust you on the SIP headers sent by
voip_test. I only have a few minor style points. I'm not hung up on them

In “Update the groups interface when remote user accepts the call.”:

+          TpIntSet *set;
+          set = tp_intset_new ();
+          tp_intset_add (set, peer);

I guess I'd spell this as TpIntSet *set = tp_intset_new_containing (peer);.

+        elif message.method == 'OPTIONS':
+            # FIXME: work out why sofiasip keeps sending s:REGISTRATION PROBE
+            return

Is there a bug for this?

+            assert self._aline_template % locals() in sdp_string

How about assertContains?

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the telepathy-bugs mailing list