[Bug 32979] Add extensions to allow accounts to be hidden from the main AccountManager interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32979

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-14 02:29:59 PST ---
(In reply to comment #2)
> Minor quibble: The interface alread has Hidden in its name,
> and only deals with hidden accounts, so I think it would be
> better not to have "Hidden" also in the properties and methods:
> 
> ie:
> 
>   Blah.Hidden.ValidAccounts
> 
> rather than:
> 
>   Blah.Hidden.ValidHiddenAccounts
> 
> Admittedly a very minor point: Other than that, looks fine.

This is to work around a dbus-glib bug. The signal names need to be unique
across all interfaces implemented by an object. So
AM.I.Hidden.HiddenAccountValidityChanged can't be called
AM.I.Hidden.AccountValidityChanged, because this conflicts with
AM.AccountValidityChanged.

(It works by objects emitting corresponding GObject signals; unfortunately the
names dbus-glib expects are based only on the signal name, not on the interface
too.)

It makes me unhappy too! The properties only have stupid redundant names for
consistency, so I could rename those, depending on whether brevity in property
names is worth the inconsistency.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.