[Bug 32902] review Pidgin log store and dbus testsuite

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32902

Emilio Pozuelo Monfort <pochu27 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pochu27 at gmail.com

--- Comment #6 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-01-14 10:09:37 PST ---
(In reply to comment #5)
> > >diff --git a/tests/dbus/test-tpl-log-store-pidgin.c b/tests/dbus/test-tpl-log-store-pidgin.c
> > >+++ b/tests/dbus/test-tpl-log-store-pidgin.c
> > >@@ -0,0 +1,576 @@
> > >+/* FIXME: hugly kludge: we need to include all the declarations which are used
> > >+ * by the GInterface and thus not in the -internal.h */
> > >+#include "../../telepathy-logger/log-store-pidgin.c"
> > 
> > It's really hugly, anything we could do about that ?
> 
> The way to fix it would be export symbols in a .h just for testing uses.

JFTR, when I did the log manager refactoring I noticed some symbols where in
-internal.h headers just for the tests. It probably doesn't hurt to do that...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.