[Bug 31583] Expose TpProxyFeature in the API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31583

--- Comment #13 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-01-18 06:13:51 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > Does that mean that if we have MY_CHANNEL_CORE_FEATURE, we shouldn't call its
> > prepare function while TP_CHANNEL_CORE hasn't be prepared? We don't do that
> > atm.
> 
> Yes, I think we should avoid preparing subclasses' core features until the
> superclass's core feature is ready. I'm aware that this is a new guarantee that
> we didn't previously have, but I think the semantics I proposed here are
> probably what we want.

I agree, that's better. I've done that.

> Still missing:
> - Improve CORE dependencies (see above) ?

done.

> - Add can_retry

done.

> - add prepare_after_connected()

Done. I finally went for prepare_before_signalling_connected_async() as it's
clearer ({before,after}_connected can both make sense and so are pretty
confusing imho) but I'm open to a better suggestion.

Any chance you could take a quick look on my branch and see if it fits what
you had in mind ?

> - Make the API public

That's still TODO.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.