[Bug 32053] Add a TpContactSearch proxy object

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 19 17:49:41 CET 2011


--- Comment #31 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-01-19 08:49:40 PST ---
(In reply to comment #30)
> + * @self: a contact search object
> We usually use "A #TpContactSearch"

Hmm, in comment 20, Simon said I shouldn't do "a #gboolean" for a gboolean
param, because it's obvious. This looks similar to me.

> (In reply to comment #29)
> > > I think the long description in SECTION:contact-search should describe the
> > > whole search process (which function use to start a search, how to get the
> > > results and then how to start a new search).
> > 
> > I've added a paragraph explaining how a normal search would be done.
> Nice,for the sack of completeness, you may add that the signal can be fired
> more than once and how we can detect that the search is done.


> > > Actually having a simple demo app in examples/client could be useful.
> > 
> > Can we postpone this? I'd like to get contact search in Empathy, and the UI
> > freeze is in ~ 1 week, and it's blocking on this.
> Sure, just opens a bug so we don't forget.

Will do when this is merged.

> > > > > Having test for TpContactSearch would make me an happier badger...
> > > > 
> > > > I tried to look at this, but apparently I need to create some classes for the
> > > > DBus tests and I couldn't really understand how that stuff works.
> > > 
> > > Yeah you have to write a server side channel object to test your API.
> > > See for example tests/lib/stream-tube-chan.c tested in tests/dbus/stream-tube.c
> > 
> > Same as for the example... can we do this later? I don't really have the time
> > right now to get into this, and I'm sure this will take me quite some time as
> > I'm not familiar with this dbus test stuff.
> I'm not really happy adding completely untested new API, but I understand than
> we don't have much time here. If that's fine with the maintainer (smcv), then
> ok.

I guess by untested you mean "without unit tests", since it's tested (I'm using
it for the Empathy contact search dialog, and it works fine).

> I'd also like to get the API reviewed by smcv before merging as he's the
> tp-glib API master.

Sure. Thanks for all your comments!

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the telepathy-bugs mailing list