[Bug 33213] Rename _get_events() to get_entities()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 20 15:14:19 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33213

--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-01-20 06:14:18 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > > -      _search_new_async_result_free);
> > > +      (GDestroyNotify) tpl_log_manager_search_free);
> > > 
> > > I don't think you need the cast here.
> > 
> > The arg1 type is not a void*, thus GCC complains, that's why it's required.
> 
> GDestroyNotify has a gpointer arg, and tpl_log_manager_search_free has the same
> too. Both return void. I don't understand why it is needed... Plus I think in
> another place you don't cast it.
> 
> Good to go otherwise.

void tpl_log_manager_search_free (GList *hits);
void (*GDestroyNotify)           (gpointer data);

As you can see, one has GList* and the other gpointer, this is enough to
generate compilation warning. Thanks for the review.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list