[Bug 32390] Creating a search channel on a "" (empty string) server fails without an error

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 24 12:49:08 CET 2011


--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-01-24 03:49:07 PST ---
Yes the first commit is confusing to me too.

-    call_create(q, conn, server=None)
-    answer_field_query(q, stream, JUD_SERVER)
+    call_create(q, conn, server=server)
+    ret, _ = answer_field_query(q, stream, JUD_SERVER)

This looks wrong in this context alone and looking at the commit message, but
actually am I right in thinking you changed the test and then committed
patch-by-patch? I don't think "server" has been set by now and so this code
belongs in the top commit, no?

If so, then it'd be nice if you just changed "server=server" back to
"server=None" so that test at that point doesn't fail (so we don't have broken

But maybe I'm wrong?!

Other than that it looks good to me too.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list