[Bug 32434] FileTransfer: add a way to pass the outgoing file to the Handler

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jan 25 12:47:16 CET 2011


Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
             Blocks|18527                       |

--- Comment #6 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-01-25 03:47:15 PST ---
(In reply to comment #3)
> So you're proposing:
> prop LocalFilePath (rw):
>     tp:requestable
>     tp:immutable='sometimes'

Maybe FileURI so we can use gio magic to send/receive files from/to remote
Note that would make things more complex if we use this property as a file
transfer method with the CM (a CM may not support, say, ftp://);

> There's a race:
> • Handler sets LocalFileURI
> • Handler calls AcceptFile(); CM returns really quickly, and emits
> FileTransferStateChanged(Open)
> • Observer calls Get(LocalFileURI), but due to a quirk of the scheduler the
> message doesn't get sent for a while.
> • Handler gets the entire file.
> • CM emits FileTransferStateChanged(Completed)
> • Handler calls Close()
> • The observer's method call finally gets delivered, and fails.
> So I think we need change notification. LocalFileURISet(s: Local_File_URI)
> doesn't seem so bad.

That's a bit of a corner case but yeah, ok. Adding this signal is trivial any

(In reply to comment #4)
> (In reply to comment #3)
> Also, if a CM supported a hypothetical Address_Type_Local_File, the handler
> could just pass that and the file path as the Access_Control_Param to
> Accept/Provide… ;-)

That's bug #18527, I added a comment.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list