[Bug 33404] Move caps hash stuff to Wocky

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33404

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|i guess this is kind of a   |
                   |review-                     |

--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-01-26 02:33:35 PST ---
(In reply to comment #1)
> I think WockyDiscoIdentity should probably be a boxed type.

Done.

(In reply to comment #5)
> You updated the hashing test in Gabble. That test should be in Wocky if the
> hashing has moved there.

Done.

(In reply to comment #0)
> 12:57 < wjt> jonnylamb: the data form parser should use WockyDataForm
> 12:57 < wjt> s/use/be replaced by using/

Done.

(In reply to comment #3)
> It's actually not entirely clear to me that there's any value in
> WockyDiscoIdentity having accessors for all its fields, rather than the caller
> just using identity->type and friends.

Okay, sure, I just copied them from gabble. They're gone.

> g_return_val_if_fail (source != NULL, NULL);

Done.

> if (arr == NULL)
>   return;

Done.

> It's 2011.

You're right!

> On top of _compute_from_node(), shouldn't there be a function that computes a
> hash from a list of features, identities, and data forms? Otherwise
> Gabble/Salut will need to build up a WockyNode whenever they need to hash their
> caps… oh! they have to do this anyway, I suppose maybe?

Done.

(In reply to comment #4)
> +#ifndef __WOCKY_PLUGINS_DISCO_IDENTITY_H__

Fixed.

> I think the guts of this function should be wocky_disco_identity_cmp
> (WockyDiscoIdentity *a, WockyDiscoIdentity *b). But obviously you'll still need
> the wrapper for GPtrArray silliness.

Done.

>   * Computes verification string hash according to XEP-0115 v1.5
> 
> Hashes plural.

Fixed.

> I don't think this is a particularly useful comment, honestly. The “does not do
> anything with” bit is liable to become wrong. I imagine we'll ultimately have
> something like:

You're the boss, removed.

Okay that's that. You're free to take another swing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.