[Bug 32053] Add a TpContactSearch proxy object

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32053

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |review+ with one change

--- Comment #35 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-26 09:25:28 PST ---
(In reply to comment #34)
> > ::: telepathy-glib/contact-search-result.c
> > @@ +38,3 @@
> > + *
> > + * #TpContactSearchResult objects represent results for
> > + * #TpContactSearch.
> > 
> > it representS results.
> 
> I say "objects", so it's "objects represent", no? I could say
> "TpContactSearchResult represents..." if you prefer that.

Erm. Yeah. It's correct as it is. I can't read, obviously. :)

+  if (self->priv->fields != NULL)
+    {
+      g_list_free_full (self->priv->fields,
+          (GDestroyNotify) tp_contact_info_field_free);
+      self->priv->fields = NULL;
+    }

You don't need the NULL check. NULL is the empty GList.

> Any other stuff, or can we merge this? :-)

Fix the above, file a bug for improving the documentation, and then gogogo.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.