[Bug 33546] Refactore and cleanup TplEvent/TplEventText

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 26 21:54:30 CET 2011


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
                URL|                            |http://git.collabora.co.uk/
                   |                            |?p=user/nicolas/telepathy-l
                   |                            |ogger.git;a=shortlog;h=refs
                   |                            |/heads/event-refactoring
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
         AssignedTo|telepathy-bugs at lists.freede |nicolas.dufresne at collabora.
                   |sktop.org                   |co.uk
         Depends on|                            |32902
             Blocks|                            |27271

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-01-26 12:54:30 PST ---


commit 0456844fe7b6ea9009d974d0e26bfeec710747c9
Author: Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>
Date:   Wed Jan 26 15:37:28 2011 -0500

    Refactored TplEvent/TplEventText

    This is a refactoring/cleanup of TplEvent/TplEventText classes. Main
    changes are:

    - Removal of all the setters in -private.h files
    - Made properties construct only
    - Moved pending-msg-id to TplEvent
    - Made _get_message_type() public (bug #27621)
    - Moved/Renamed _text_is_charoom() to tpl_event_target_is_room()
    - Removed TplEventTextSignalType
    - Remove incomplete allocators (in favor of g_object_new())

    Note that while porting the log-store I accidently fixed a bug in Pidgin
    log-store where message body is always NULL, this is now reflected in
    the test.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list