[Bug 32434] FileTransfer: add a way to pass the outgoing file to the Handler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32434

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ with wording tweaks

--- Comment #14 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-28 05:48:31 PST ---
+        <p>For outgoing file transfers, most of the time this URI will be a
+        file but it MAY be something else; if we're streaming
+        a web page to a contact for example.</p>

+        <p>For incoming file transfers, this URI MUST be a file.</p>

I'd replace both of these with a single paragraph:

    If set, this URL SHOULD generally point to a file on the local system, as
defined by <a href='http://www.apps.ietf.org/rfc/rfc1738.html#sec-3.10'>RFC
1738 §3.10</a>; that is, it should be of the form <tt>file:///path/to/file</tt>
or <tt>file://localhost/path/to/file</tt>. For outgoing files, this URL MAY use
a different scheme, such as <tt>http:</tt>, if a remote resource is being
transferred to a contact.

Pedantically, this property should be URL, not URI: we want this to be a
locator, not an identifier. See
<http://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Relationship_to_URL_and_URN>:
file:, http: and friends are the kinds of URI we want, not urn:xmpp:jingle:1,
no matter how much I love that protocol.

But besides that I think this is good to go. I don't mind *that* much about URL
vs. URI.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.