[Bug 38801] Missing _async() wrappers for Channel.Group, Connection.ContactList and Connection.ContactGroups interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38801

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-01 03:01:15 PDT ---
Review of attachment 48645:
 --> (https://bugs.freedesktop.org/review?bug=38801&attachment=48645)

I just reviewed the top 3 patches. Do we really want to expose those as high
level API. Shouldn't we have an higher level / easier API instead?

::: telepathy-glib/channel-contacts.c
@@ +49,3 @@
+ *
+ * Invite all the given @contacts into the channel, or accept requests for
+ * channel membership for @contacts on the pending local list.

This is pretty cryptic if you are not a Telepathy expert. If the goal of this
function is to invite people to a channel, then it should be call _invite(). If
it it to accept an invitation it should be _accept_invite().

@@ +56,3 @@
+tp_channel_group_add_members_async (TpChannel *self,
+    guint n_contacts,
+    TpContact * const *contacts,

Do we really want to use the n_contacts + *contacts pattern here? In practice,
user will always has to allocate a GArray and pass array->data, array->len. The
only simpler case is when passing only one contact for which I'd prefer to have
another simpler API.

@@ +78,3 @@
+ * Finishes tp_channel_group_remove_members_async()
+ *
+ * Returns: %FALSE if the operation failed, %TRUE otherwise.

We usually use something like "TRUE if the operation was successful, otherwise
FALSE" which is a bit more positive. :)

@@ +102,3 @@
+ *
+ * Requests the removal of @contacts from a channel, reject their request for
+ * channel membership on the pending local list, or rescind their invitation
on

rescind?

Same problem, this function is way too complicated. High level API should
provide an easier API to use, not a direct mapping on the spec.

::: telepathy-glib/connection-contact-list.c
@@ +68,3 @@
+void
+tp_connection_request_subscription_async (TpConnection *self,
+    guint n_contacts, TpContact * const *contacts, const gchar *message,

one arg per line.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.