[Bug 38943] Implement Facebook's power saving mode

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 5 19:33:29 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38943

--- Comment #2 from Marco Barisione <marco.barisione at collabora.co.uk> 2011-07-05 10:33:28 PDT ---
(In reply to comment #1)
> Perhaps it would be better to check is_facebook() once, rather than every time
> we think about changing powersaving state? We could add
> GABBLE_CONNECTION_FEATURES_FACEBOOK_SUSPEND and set it in connector_connected()
> based on the  connection_disco_cb (probably outside the if/else; I don't know
> if Facebook is well-behaved enough to reply properly to disco queries?) or some
> similar place? This would make it consistent with the Google code.

I will take a look at this.

> Is GabbleConnection:connect-server guaranteed to be set? At least on MeeGo
> Netbook, I think we just used { 'account': 'chat.facebook.com' } for the
> account parameters; and Empathy sets { 'account': 'username at chat.facebook.com'
> }. I would like the test to test the case where 'server' is not provided, even
> if this does already work.

I think I checked this and it works fine. I can improve the test to check for
this condition too.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list