[Bug 38852] Call: Name methods like methods and signals like signals

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 5 21:15:30 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38852

--- Comment #4 from David Laban <david.laban at collabora.co.uk> 2011-07-05 12:15:30 PDT ---
(In reply to comment #3)
> Flush sounds like your throwing them away!.. And it's a signal really

The name was inspired by fflush. "CandidatesPrepared" only sounds like a signal
(past tense) because it was copy-pasted from the (inside-out-sounding)
StreamedMedia API. It is a method, which will cause rakia to do something
important (but may be ignored by gabble). It should therefore use the
imperative mood.

I'm going to brainstorm a load of other possible names. Pick the one you like
best.

FinishInitialCandidates()

SendInitialCandidates() # may be a lie if we don't have codecs yet.

DoCandidatesDance()

ProcessInitialCandidates()

ProcessCandidates() # Probably the most honest name.

Note that the purpose of this method is so that the CM can select its RawUDP
candidate. If we just created a ProvideRawUDPCandidate() it would make the
entire process more explicit.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list