[Bug 38997] Factor out some socket utility functions

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38997

Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://cgit.collabora.com/g
                   |                            |it/user/cassidy/telepathy-g
                   |                            |lib/log/?h=socket-util-3899
                   |                            |7
           Keywords|                            |patch

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-06 02:39:24 PDT ---
Here is my version
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=socket-util-38997

It's based on Morten's branch with the following changes:
- rebased on top of master

- I squashed the "create new utilty function" and "use it in TpStreamTube"
commits together. This makes reviewing easier and we can easily see if the new
function is just a factoring out of existing code.

- _tp_determine_socket_address_type() and _tp_determine_access_control_type()
  are now statics as they weren't used outside of util.c

- _tp_set_socket_address_type_and_access_control_type() now directly pass the
GError from the caller rather than using its own and use g_propagate_error().

- I re-ordered the arguments of _tp_create_local_socket so the (out) args are
last.

- _tp_create_local_socket(): set unix_address to NULL if we create an Inet
socket.

- Some coding style fixes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.