[Bug 38249] Add API for the ChannelRequest.DelegateToPreferredHandler hint

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38249

--- Comment #9 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-07-06 16:23:45 PDT ---
Review of attachment 48760:
 --> (https://bugs.freedesktop.org/review?bug=38249&attachment=48760)

Did you forget to add account-channel-request-internal ?

::: docs/reference/Makefile.am
@@ +65,3 @@
 IGNORE_HFILES=\
     add-dispatch-operation-context-internal.h \
+    account-channel-request--internal.h \

Double dash?

::: telepathy-glib/account-channel-request.c
@@ +851,3 @@
+  g_assert (TP_IS_CHANNEL (channel));
+  g_assert_cmpstr (tp_proxy_get_object_path (channel), ==,
+

Are assertions appropriate here, or would g_return_if_fail() be better?

@@ +1673,3 @@
+ * channels.
+ *
+ *

Is there a word missing here?

@@ +1682,3 @@
+ * channel.
+ *
+ * When receiving a request containing this hint, @self will automatically

Consider a See Also: to the TpBaseClient description?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.