[Bug 38249] Add API for the ChannelRequest.DelegateToPreferredHandler hint

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38249

--- Comment #10 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-07 02:06:05 PDT ---
(In reply to comment #9)
> Review of attachment 48760 [details]:
> 
> Did you forget to add account-channel-request-internal ?

I did :(

> ::: docs/reference/Makefile.am
> @@ +65,3 @@
>  IGNORE_HFILES=\
>      add-dispatch-operation-context-internal.h \
> +    account-channel-request--internal.h \
> 
> Double dash?

Ooops, fixed;

> ::: telepathy-glib/account-channel-request.c
> @@ +851,3 @@
> +  g_assert (TP_IS_CHANNEL (channel));
> +  g_assert_cmpstr (tp_proxy_get_object_path (channel), ==,
> +
> 
> Are assertions appropriate here, or would g_return_if_fail() be better?

g_return_if_fail() is probably better indeed; changed.

> @@ +1673,3 @@
> + * channels.
> + *
> + *
> 
> Is there a word missing here?

??

Btw, I renamed it to tp_account_channel_request_set_delegated_channel_callback
(singular) as there is only one channel being delegated in this case.

> @@ +1682,3 @@
> + * channel.
> + *
> + * When receiving a request containing this hint, @self will automatically
> 
> Consider a See Also: to the TpBaseClient description?

done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.