[Bug 31376] TpFileTransferChannel : high level API for FT

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31376

--- Comment #22 from Xavier Claessens <xclaesse at gmail.com> 2011-07-12 01:35:02 PDT ---
+  features[FEAT_CORE].name = TP_FILE_TRANSFER_CHANNEL_FEATURE_CORE;
+  features[FEAT_CORE].core = TRUE;

Does that mean the feature will be prepared automatically at object
construction, or just that if we call tp_proxy_prepare_async() that feature
will be prepared first? Also you forgot to list it in the automatic factory's
dup_features().

+    /* Hidden properties */
+    GHashTable *available_socket_types;

For string properties it is obvious that they are borrowed from
immutable_properties table because they are "const gchar *" but you should
comment that this GHashTable is borrowed too, was wondering why it is not
unreffed in dispose/finalize. Note that you could actually ref it (that's
cheap,  unlike strings).

TpFileTransferChannel:content-type:

This is actually a MIME type according to spec. This property name is confusing
because in GLib world content-type != mime-type: "A content type is a platform
specific string that defines the type of a file. On unix it is a mime type, on
win32 it is an extension string like ".doc", ".txt" or a percieved string like
"audio"." See for example g_content_type_from_mime_type().

+  /**
+   * TpFileTransferChannel:size
+   *
+   * A 64-bit guint holding the size of the file to be transferred.
s/A 64-bit guint/A guint64/ ? Should be a

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.