[Bug 38142] proxy factories

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38142

--- Comment #47 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-15 02:41:39 PDT ---
You should add in TpSimpleClientFactory's doc which features are asked to be
prepared by default.


 * @create_account_manager: virtual method used to create a #TpAccountManager;
 *  see tp_simple_client_factory_dup_account_manager()
tp_simple_client_factory_dup_account_manager() doesn't exist any more.

Ditto for the others.


static TpConnection *
create_connection_impl (TpSimpleClientFactory *self,
    const gchar *object_path,
    GError **error)

Shoudln't we do something like:

static TpConnection *
create_connection_impl (TpSimpleClientFactory *self,
    const gchar *bus_name,
    const gchar *object_path,
    GError **error)

to stay coherent with tp_connection_new and allows user to create TpConnection
from their bus name rather than their path?


I do beliver that oa{sv} (object-path and immutable properties) is the right
way to advertise objects and that we should use it everywhere in
Telepathy. As we are "about" to break the D-Bus API maybe we could add a
"GHashTable *immutable_propertiers" argument to all of these methods to be
future proof?

A few lines are still too long, you should configure your editor to mark them
in red or something:
  tp_clear_pointer (&self->priv->desired_account_manager_features,
g_array_unref);
  connection = TP_SIMPLE_CLIENT_FACTORY_GET_CLASS (self)->create_connection
(self,
tp_simple_client_factory_ensure_channel_dispatch_operation
(TpSimpleClientFactory *self,

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.