[Bug 38801] Missing _async() wrappers for Channel.Group, Connection.ContactList and Connection.ContactGroups interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38801

--- Comment #20 from Xavier Claessens <xclaesse at gmail.com> 2011-07-15 04:29:45 PDT ---
(In reply to comment #16)
> Review of attachment 49126 [details]:
> 
> ::: docs/reference/telepathy-glib-sections.txt
> @@ +3543,3 @@
>  tp_contact_info_list_copy
>  tp_contact_info_list_free
> +<SUBSECTION contact-list>
> 
> You should either add
> <INCLUDE>telepathy-glib/connection-contact-list.h</INCLUDE>
> or include it in connection.h

It should be the global telepathy-glib.h actually. Fixed.

> ::: telepathy-glib/connection-contact-list.c
> @@ +49,3 @@
> +    g_return_if_fail (TP_IS_CONNECTION (self)); \
> +    g_return_if_fail (tp_proxy_has_interface_by_id (self, \
> +        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_LIST)); \
> 
> Isn't this too much? That means apps will have to check if the connection does
> implement CL before using this function if they don't want to raise a critical.

I'm not going to make fallbacks to legacy contact-list channels, so we really
need ContactList iface. It's better to warn loudly than having apps relying on
wrong assumptions. I think apps should wait for ContactList to be implemented
into tp-python though.

> @@ +72,3 @@
> + * @message: an optional plain-text message from the user, to send to those
> + *  @contacts with the subscription request. The
> + *  #TpConnection:request-uses-message property indicates whether this message
> 
> This property doesn't exist yet.

right, dropped that part.

> ::: telepathy-glib/connection-contact-list.h
> @@ +1,2 @@
> +/*
> + * connection.h - proxy for a Telepathy connection
> 
> bouh

Fixed


(In reply to comment #17)
> Review of attachment 49127 [details]:
> @@ +315,3 @@
> +        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_GROUPS)); \
> +    g_return_if_fail (_tp_contacts_to_handles (self, n_contacts, contacts, \
> +    GArray *handles; \
> 
> add g_return_if_fail (group != NULL);

fixed

> @@ +496,3 @@
> +    g_return_if_fail (tp_proxy_has_interface_by_id (self,
> +        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_GROUPS));
> +}
> 
> check group != NULL
fixed

> @@ +555,3 @@
> +    g_return_if_fail (tp_proxy_has_interface_by_id (self,
> +        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_GROUPS));
> + * @callback: a callback to call when the operation finishes
> 
> Same here, for boths.

fixed

(In reply to comment #18)
> Review of attachment 49128 [details]:
> 
> ::: docs/reference/telepathy-glib-sections.txt
> @@ +4210,3 @@
>  tp_contact_set_contact_groups_finish
>  tp_contact_has_feature
> +<SUBSECTION operations>
> 
> Same problem regarding the included header.

fixed

> ::: telepathy-glib/contact-operations.c
> @@ +1,3 @@
> +/* Async operations for TpContact
> + *
> + * Copyright (C) 2011 Collabora Ltd. <http://www.collabora.co.uk/>
> 
> I'm sure Will won't approve this without a proper ©

fixed

> @@ +32,3 @@
> + * @user_data: data to pass to @callback
> + *
> + * Convenient wrapper for tp_connection_request_subscription_async() on single
> 
> "on a single contact" ? Not sure, check with a native.

fixed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.