[Bug 38801] Missing _async() wrappers for Channel.Group, Connection.ContactList and Connection.ContactGroups interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38801

--- Comment #22 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-15 04:38:58 PDT ---
(In reply to comment #20)
> > ::: telepathy-glib/connection-contact-list.c
> > @@ +49,3 @@
> > +    g_return_if_fail (TP_IS_CONNECTION (self)); \
> > +    g_return_if_fail (tp_proxy_has_interface_by_id (self, \
> > +        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_LIST)); \
> > 
> > Isn't this too much? That means apps will have to check if the connection does
> > implement CL before using this function if they don't want to raise a critical.
> 
> I'm not going to make fallbacks to legacy contact-list channels, so we really
> need ContactList iface. It's better to warn loudly than having apps relying on
> wrong assumptions. I think apps should wait for ContactList to be implemented
> into tp-python though.

I agree, but shouldn't we fail the async operation rather than potentially
crash the app? g_return_if_fail() are used if the app did something wrong but
in that case it's not its fault if a CM is too old.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.