[Bug 38142] proxy factories

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38142

--- Comment #60 from Xavier Claessens <xclaesse at gmail.com> 2011-07-20 05:22:01 PDT ---
Thanks for the doc tweaks!

I've cherry-picked 37bb2dde30f6d8cb66e7c5a8a87c884a6d52ec5c and
ec40be527645607f91b30beaad1b2a38258d60ee and merged into master since they are
unrelated.

(In reply to comment #59)
> +      /* A common usage is request_and_handle, in that case EnsureChannel
> +       * returns only the object-path of the ChannelRequest but not
> properties.
> +       * The TpChannelRequest will be created with no properties, then when
> +       * handling we get the properties and we reuse the same TpChannelRequest
> +       * object, and we can give it the immutable-properties. */
> 
> Eh? This doesn't sound right. The client library should know the immutable
> properties of the ChannelRequest that EnsureChannel() returns because it
> specified them when it called EnsureChannel().

I don't know how this is supposed to work, but fact is TpBaseClient creates
TpChannelRequest objects without giving immutable properties, then create
another with the immutable_properties. If you remove that workaround, you'll
see unit tests failing. I should probably add a FIXME in that comment and open
a bug to fix TpBaseClient so it always gives the immutable-properties? I would
like to not block on this, factories have been waiting for too long already.

Do you have any other comments, is your branch ready to get merged now?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.