[Bug 21168] Idle doesn't implement Connection.Interface.Contacts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21168

--- Comment #12 from Xavier Claessens <xclaesse at gmail.com> 2011-07-21 03:47:40 PDT ---
Review of attachment 49353:
 --> (https://bugs.freedesktop.org/review?bug=21168&attachment=49353)

small coding style, otherwise +1

::: src/idle-connection.c
@@ +227,3 @@
     priv->msg_queue = g_queue_new();
+
+    tp_contacts_mixin_init((GObject *) obj, G_STRUCT_OFFSET(IdleConnection,
contacts));

missing space _init () and OFFSET ()

@@ +409,2 @@
     g_queue_free(priv->msg_queue);
+    tp_contacts_mixin_finalize(object);

missing space _finalize ()

@@ +483,3 @@
     g_object_class_install_property(object_class, PROP_PASSWORD_PROMPT,
param_spec);

+    tp_contacts_mixin_class_init(object_class,
G_STRUCT_OFFSET(IdleConnectionClass, contacts));

missing space _init () and OFFSET ()

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.