[Bug 39448] [RFE, PATCH] Add Tracker based TplLogStore

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39448

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-07-22 14:41:12 PDT ---
Review of attachment 49389:
 --> (https://bugs.freedesktop.org/review?bug=39448&attachment=49389)

Didn't look at the actual code yet (coming soon), but I noticed many coding
style errors, TP logger should be following Telepathy coding style
http://telepathy.freedesktop.org/wiki/Style.

::: configure.ac
@@ -157,0 +157,12 @@
+# -----------------------------------------------------------
+# Tracker optional support
+# -----------------------------------------------------------
... 9 more ...

All this should be configurable using --with-tracker= [auto/yes/no, default
auto] where using yes would make it fail if tracker dependency is not met, and
no would simply disable it without checking dependency.

::: telepathy-logger/Makefile.am
@@ -130,1 +138,5 @@
 TelepathyLogger_0_2_gir_INCLUDES = GObject-2.0 TelepathyGLib-0.12
+
+if HAVE_TRACKER_MINER
+TelepathyLogger_0_2_gir_INCLUDES += TrackerMiner-0.11
+endif

Move the if HAVE... block to the end.

::: telepathy-logger/log-store-factory.c
@@ -50,2 +50,3 @@
   key = g_strdup (logstore_type);

+  g_print (">>>> %s\n", logstore_type);

To be removed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.