[Bug 39464] gabble shouldn't crash on malformed caps

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39464

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-07-28 07:41:08 PDT ---
My reading of XEP-0004 is that the type='' attribute is mandatory, and that in
this case it ought really to be result.

<http://xmpp.org/extensions/xep-0004.html#protocol-formtypes> describes
type='result' as “… the data is a generic data set.”.
<http://xmpp.org/extensions/xep-0004.html#schema> says that the type=''
attribute is mandatory.

So qutim is buggy. But clearly so are we. :)

Your patch looks good; here's a regression test for Gabble:
<http://cgit.collabora.com/git/user/wjt/telepathy-gabble-wjt.git/commit/?h=null-caps-39464>.
The regression test's form is malformed in more crucial ways, too: the form
type='' attribute is not part of the XEP-0115 hash, but the FORM_TYPE field
(which is different!) is, so omitting it makes for a genuinely unhashable disco
reply, even in the presence of a fault-tolerant parser. I tweaked Wocky to
accept the absence of type='' (which I don't think we should do, but some
future person might) and the test still passed without crashing Gabble, so
that's fine then.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.