[Bug 39652] New: Gabble crashes on connecting account (wocky_caps_hash_compute_from_node returns a NULL string)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39652

           Summary: Gabble crashes on connecting account
                    (wocky_caps_hash_compute_from_node returns a NULL
                    string)
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: daniele.domenichelli at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Created an attachment (id=49693)
 View: https://bugs.freedesktop.org/attachment.cgi?id=49693
 Review: https://bugs.freedesktop.org/review?bug=39652&attachment=49693

Use tp_strdiff instead of g_str_equal

The problem is in presence-cache.c:1318

  if (g_str_equal (waiter_self->ver, computed_hash))

computed_hash = wocky_caps_hash_compute_from_node (query_result) and
computed_hash is NULL

The attached patch fixes the crash using tp_strdiff instead of g_str_equal, but
I don't know why wocky fails to compute hash, and I cannot reproduce the bug
every time (and at the moment I cannot reproduce it to add a debug log to the
bug report, sorry)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.