[Bug 33857] Gabble disconnects on: "Error receiving stanza: Namespace prefix xmlns on server is not defined "

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33857

Catalin Patulea <cat at vv.carleton.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cat at vv.carleton.ca

--- Comment #1 from Catalin Patulea <cat at vv.carleton.ca> 2011-06-03 21:24:58 PDT ---
Hitting this with 0.10.0 with a similar stanza.

Looks like the problem is a malformed tag in the iTeleport stanza:

$ cat /tmp/stanza.xml 
<presence from="trivex at gmail.com/iTeleport Connect.MAC.71AE9956"
to="cronos586 at gmail.com/10719d02">
  <nick xmlns="http://jabber.org/protocol/nick">tw-growth-pair</nick>
  <type xmlns="">MAC</type>
  <id xmlns="">vnc</id>
  <xmlns:server xmlns="http://www.w3.org/2000/xmlns/"/>
  <server xmlns=""/>
  <show>offline</show>
  <invisible value="true"/>
  <priority>-127</priority>
  <name xmlns="">iTeleport Connect</name>
  <version xmlns="">5.0.10</version>
  <ssh-enabled xmlns="">false</ssh-enabled>
  <automanage-vnc xmlns="">true</automanage-vnc>
  <encryption-enabled xmlns="">true</encryption-enabled>
  <router-mac-address xmlns=""/>
  <status/>
  <x xmlns="vcard-temp:x:update">
    <photo>fae6150c7aefa1b5ff46baff04b39d3ee52dd118</photo>
  </x>
</presence>

$ python -c 'import libxml2; libxml2.parseFile("/tmp/stanza.xml")'
/tmp/stanza.xml:5: namespace error : reuse of the xmlns namespace name is
forbidden
  <xmlns:server xmlns="http://www.w3.org/2000/xmlns/"/>
                                                     ^
/tmp/stanza.xml:5: namespace error : Namespace prefix xmlns on server is not
defined
  <xmlns:server xmlns="http://www.w3.org/2000/xmlns/"/>

The W3C recommendation on namespaces
(http://www.w3.org/TR/REC-xml-names/#ns-decl) says that you can't redeclare the
'http://www.w3.org/2000/xmlns/' namespace, which is what that 'xmlns:server'
tag is trying to do.

It's not clear to me whether this is a bug in iTeleport, the Google XMPP server
implementation, Gabble, or all of the above:

* iTeleport definitely shouldn't be sending out malformed XML.
* Google XMPP should (?) not accept malformed XML from its clients.
* Gabble should gracefully handle this type of error, and ignoring the presence
IQ, rather than crashing entirely.

Is this fixed in newer versions of gabble?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.