[Bug 35128] Call: CallState, CallFlags, & CallState are confusing

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35128

--- Comment #9 from David Laban <david.laban at collabora.co.uk> 2011-06-10 17:28:33 PDT ---
(In reply to comment #7)
> "Codecs Incompatible" vs "CodecsIncompatible" or is that normal ? And same for
> other errors.xml changes. Anyway, the html is not generated correctly here when
> you refer to them.
> 

Good catch. Tell my when you find a fix for that.

> Alerting vs SetRinging .. Inconsistent naming, Why did you rename Ringing to
> Alerting anyway ?

It was to a) make it so that the CallFlags and MemberFlags' Ringing members the
place to tell whether you're ringing or not if you care and b) copy-pasta from
rfc3976#section-5. I think you're right though: Ringing is probably more
natural.

> 
> I dislike Streaming_Error (sounds like Media Error), you really mean
> "Connection_Failed_Error"

Streaming Error is better than Connection_Failed_Error. There is a tp:error
with the name ConnectionFailed already. It is different from MediaError for
those technically minded enough to care. If we want to avoid the name
collision, we could rename MediaError to CodecError or something?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.