[Bug 28366] Add DBusTube interface support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28366

--- Comment #15 from Olli Salli <ollisal at gmail.com> 2011-06-26 10:51:40 PDT ---
(In reply to comment #14)
> Whoops, forgot to write here. All of the issues in the branch have been fixed

Yes, the API and code look basically okay now.

> and pushed, except for docs, for which I'm waiting for Andre's mail as you
> previously suggested.
> 

Well, that was mostly for stream tubes, as that's what Andre has been working
on lately. But yeah, some of his suggestions will surely apply to the DBus tube
class documentation as well.

> Unit tests are kind of a problem. Tp-glib has no class for implementing dbus
> tubes tests, and I wonder if I should take care of that and try to create it,
> or act differently.

Well. There is no ready made test service, no. That's because there is no
high-level client-side API for dbus tubes in tp-glib either, so nothing
requires such a service for testing.

This only means that you have to create the test service yourself, probably by
modifying tp-glib's StreamTube channel test service as I mentioned in a
previous comment. tp-glib surely does have the needed low-level service classes
for implementing a dbus tube channel (one could perhaps look at gabble for
reference on how to use that). There's also TpGroupMixin for implementing the
Group interface for testing the bus name monitoring stuff in addition to
implementing the basic Channel stuff by deriving from TpBaseChannel.

In any case, automated regression tests are a must for this code. The fact that
there is no ready-made test service already written by someone else is no
excuse against that; after all we wouldn't have any unit tests at all if
somebody didn't write the test service at first.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.