[Bug 33404] Move caps hash stuff to Wocky

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33404

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://cgit.freedesktop.org
                   |?p=user/jonny/wocky.git;a=s |/~jonny/wocky/log?h=caps-ha
                   |hortlog;h=refs/heads/caps-h |sh
                   |ash                         |
  Status Whiteboard|review-                     |

--- Comment #9 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-03 05:18:19 PST ---
(In reply to comment #8)
> ? The patch as it stands would leave type = 0 in some cases?

I'd changed it to do the same thing as you did later but not as nicely, I'm now
using the node iter.

> I don't see any reason why this assertion is valid, given that this is data
> received over the network.

Fair, fixed.

>     1. Append the value of the "var" attribute, followed by the '<'
>        character.
>     2. Sort values by the XML character data of the <value/> element.
>     3. For each <value/> element, append the XML character data,
>        followed by the '<' character.
> 
> Please add a test case which hashes two forms which differ only in the order of
> their values.

There is a test for testing sorting dataforms and not only are the forms are in
a different order but the values are jumbled up too. I don't see how a test
that just jumbles up value ordering would give any more?

> Also how does this deal with forms with fields of types other than text-single
> or text-multi?

Well, it won't include the field in the hash to SHA. I've included a debug
message now.

> Why does copy critical, but free merely early-return?

Well it's like g_free()? I guess not as g_free() early returns too. Okay, I'll
do the same here.

> We should fail the entire hashing process if the form is malformed, or we'll
> get confused. *Particularly* if it's our own form that's malformed.

Fixed.

Check out my branch, homey.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.